Dynomotion

Group: DynoMotion Message: 3978 From: Kyryl Perederiy Date: 2/19/2012
Subject: UpdateCurrentPositions() method
Brad -
 
I have a question for you. What has happened to the good old KM_CoordMotion.UpdateCurrentPositions() method? Was there any reason to remove it? I’m trying v4.29z and it’s not there anymore...
 
When I’m trying to replace it with UpdateCurrentPositionsABS method, everything breaks for some reason. For example, if I do Jog and then StraightFeed, the jog works fine but the feed executes in a very strange manner and loses position in violent way.
 
Thanks,
Kyryl
Group: DynoMotion Message: 3983 From: Brad Murry Date: 2/20/2012
Subject: Re: UpdateCurrentPositions() method

Hello Kyryl,

 

The KM_CoordMotion.UpdateCurrentPositions() was moved to KM_Interpreter. ReadAndSyncCurPositions().

 

 

They both do the same thing, the move was due to the underlying issue depending on the SetupParams struct of the Interpreter.

 

So even if you are not directly using the interpreter, it is still safe to call.

 

 

BTW, there were a few other methods that were in CoordMotion that really belonged in Interpreter.  Prior to 4.29 CoordMotion had a global reference to Interpreter and vice versa, so things worked but were not very OO.  The new class hierarchy makes things cleaner.

 

Sorry for the inconvenience.

 

-Brad

 

From: DynoMotion@yahoogroups.com [mailto:DynoMotion@yahoogroups.com] On Behalf Of Kyryl Perederiy
Sent: Monday, February 20, 2012 12:59 AM
To: DynoMotion@yahoogroups.com
Subject: [DynoMotion] UpdateCurrentPositions() method

 

 

Brad -

 

I have a question for you. What has happened to the good old KM_CoordMotion.UpdateCurrentPositions() method? Was there any reason to remove it? I’m trying v4.29z and it’s not there anymore...

 

When I’m trying to replace it with UpdateCurrentPositionsABS method, everything breaks for some reason. For example, if I do Jog and then StraightFeed, the jog works fine but the feed executes in a very strange manner and loses position in violent way.

 

Thanks,

Kyryl
Group: DynoMotion Message: 3988 From: Kyryl Perederiy Date: 2/20/2012
Subject: Re: UpdateCurrentPositions() method
Thanks Brad! I will try ReadAndSyncCurPositions later today.
 
-Kyryl
 
From: Brad Murry
Sent: Monday, February 20, 2012 9:27 AM
Subject: RE: [DynoMotion] UpdateCurrentPositions() method
 

Hello Kyryl,

The KM_CoordMotion.UpdateCurrentPositions() was moved to KM_Interpreter. ReadAndSyncCurPositions().

They both do the same thing, the move was due to the underlying issue depending on the SetupParams struct of the Interpreter.

So even if you are not directly using the interpreter, it is still safe to call.

BTW, there were a few other methods that were in CoordMotion that really belonged in Interpreter.  Prior to 4.29 CoordMotion had a global reference to Interpreter and vice versa, so things worked but were not very OO.  The new class hierarchy makes things cleaner.

Sorry for the inconvenience.

-Brad

From: DynoMotion@yahoogroups.com [mailto:DynoMotion@yahoogroups.com] On Behalf Of Kyryl Perederiy
Sent: Monday, February 20, 2012 12:59 AM
To: DynoMotion@yahoogroups.com
Subject: [DynoMotion] UpdateCurrentPositions() method

 

Brad -

I have a question for you. What has happened to the good old KM_CoordMotion.UpdateCurrentPositions() method? Was there any reason to remove it? I’m trying v4.29z and it’s not there anymore...

When I’m trying to replace it with UpdateCurrentPositionsABS method, everything breaks for some reason. For example, if I do Jog and then StraightFeed, the jog works fine but the feed executes in a very strange manner and loses position in violent way.

Thanks,

Kyryl
Group: DynoMotion Message: 3991 From: Kyryl Perederiy Date: 2/20/2012
Subject: Re: UpdateCurrentPositions() method
Okay, I’m happy now! Everything seems to be working as expected in v4.29z with the ReadAndSynchCurInterpreterPosition().
 
Apparently this “sync” thing that this method does is quite important to get the StraightFeed() working properly after Jogs. In the GCodeInterpreter.cpp I can see that the ReadAndSyncCurPositions() method is resetting a flag and that probably does the trick for me:
 
    // force refresh and save results
    CoordMotion->m_DefineCS_valid = false;
 
I wonder if anybody is using UpdateCurrentPositionsABS() with any rate of success?
 
-Kyryl
 
Sent: Monday, February 20, 2012 10:03 AM
Subject: Re: [DynoMotion] UpdateCurrentPositions() method
 
 

Thanks Brad! I will try ReadAndSyncCurPositions later today.
 
-Kyryl
 
From: Brad Murry
Sent: Monday, February 20, 2012 9:27 AM
Subject: RE: [DynoMotion] UpdateCurrentPositions() method
 

Hello Kyryl,

The KM_CoordMotion.UpdateCurrentPositions() was moved to KM_Interpreter. ReadAndSyncCurPositions().

They both do the same thing, the move was due to the underlying issue depending on the SetupParams struct of the Interpreter.

So even if you are not directly using the interpreter, it is still safe to call.

BTW, there were a few other methods that were in CoordMotion that really belonged in Interpreter.  Prior to 4.29 CoordMotion had a global reference to Interpreter and vice versa, so things worked but were not very OO.  The new class hierarchy makes things cleaner.

Sorry for the inconvenience.

-Brad

From: DynoMotion@yahoogroups.com [mailto:DynoMotion@yahoogroups.com] On Behalf Of Kyryl Perederiy
Sent: Monday, February 20, 2012 12:59 AM
To: DynoMotion@yahoogroups.com
Subject: [DynoMotion] UpdateCurrentPositions() method

 

Brad -

I have a question for you. What has happened to the good old KM_CoordMotion.UpdateCurrentPositions() method? Was there any reason to remove it? I’m trying v4.29z and it’s not there anymore...

When I’m trying to replace it with UpdateCurrentPositionsABS method, everything breaks for some reason. For example, if I do Jog and then StraightFeed, the jog works fine but the feed executes in a very strange manner and loses position in violent way.

Thanks,

Kyryl